bjorn3 (Feb 03 2021 at 17:27): bjorn3 (Feb 03 2021 at 17:27):I have been left triage comments on a dozen issues which I think should be closed. Can someone take a look? And is it ok if I continue triaging the rest of the issues that I think should be closed?
Edit: seems like @Chris Fallin is already taking a look.
bjorn3 (Feb 03 2021 at 17:40):And is it ok if I continue triaging the rest of the issues that I think should be closed?
@Chris Fallin?
bjorn3 (Feb 03 2021 at 17:53):I got another 22 issues that can be closed in addition to the few that haven't yet been closed. Should I comment on them or list them here?
Chris Fallin (Feb 03 2021 at 18:18):@bjorn3 please feel free to keep commenting, indeed
Chris Fallin (Feb 03 2021 at 18:18):or you can close directly if it's clearly addressed -- we can always reopen if we disagree :-)
bjorn3 (Feb 03 2021 at 18:28):I don't have permission to close any issues that are not my own.
bjorn3 (Feb 03 2021 at 18:29):I am done with triage of the most obvious issues.
Chris Fallin (Feb 03 2021 at 18:29):Ah, sorry, didn't realize; in that case I'll keep following up (thanks again for this cleanup effort!)
bjorn3 (Feb 03 2021 at 18:30):no problem
bjorn3 (Feb 03 2021 at 18:40):I noticed that there are 114 issues without label indicating if it is about cranelift, wasmtime, lightbeam, peepmatic, ...: https://github.com/bytecodealliance/wasmtime/issues?page=1&q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+-label%3Acranelift+-label%3Awasi%3Aapi+-label%3Alightbeam+-label%3Awasi%3Aimpl+-label%3Acranelift%3Aarea%3Amachinst+-label%3Awasi%3Atests+-label%3Awasmtime%3Ac-api+-label%3Awasmtime+-label%3Awasmtime%3Aapi+-label%3Afuzzing+-label%3Acranelift%3Adiscussion+-label%3Awasm-proposal%3Areference-types+-label%3Acranelift%3Aarea%3Apeepmatic+-label%3Awasmtime%3Adebugging
Andrew Brown (Feb 03 2021 at 19:44):glancing at that, I think we might want to expand our label set: benchmarking, ci, optimization...
Andrew Brown (Feb 03 2021 at 19:45):but, yeah, we should start labeling some of those
bjorn3 (Feb 03 2021 at 20:19):What is the status of wasm2obj? There are several issues about it open, but I don't know if it is still supported.
bjorn3 (Feb 03 2021 at 20:21):Also the browser wasi polyfill is pretty much unsupported and doesn't support the latest wasi, right?
Andrew Brown (Feb 03 2021 at 20:35):@Dan Gohman?
bjorn3 (Feb 03 2021 at 21:04):48 issues closed. 333 left.
bjorn3 (Feb 03 2021 at 21:04):/me calls it a day
Dan Gohman (Feb 03 2021 at 21:16):I don't actually know the current status of wasm2obj. @Yury Delendik; do you know?
Yury Delendik (Feb 03 2021 at 21:18):I did not look into that for 3-4 months, no. It produced valid obj files with DWARF info when needed
Yury Delendik (Feb 03 2021 at 21:37):/me used wasm2obj only to troubleshot DWARF issues
Dan Gohman (Feb 04 2021 at 18:49):Also, yes, the wasi browser polyfill in the wasmtime tree is unsupported right now
Dan Gohman (Feb 04 2021 at 18:50):In theory we could build a new polyfill in a similar way, however one of the things we learned since building that was that hand-writtenJS polyfills that various people have end up being much simpler and smaller
bjorn3 (Mar 20 2021 at 18:18):Did another pass and opened a few PR's for easy to fix issues.
bjorn3 (Jun 22 2024 at 19:35):Another pass. The following can be closed I think:
bjorn3 (Jun 22 2024 at 19:37):If someone with appropriate permissions could take a look, that did be appreciated.
Chris Fallin (Jun 22 2024 at 23:15):Awesome, thanks for making the pass! I closed four of them; the two WASI ones (143, 273) I'll delegate to someone else (@Alex Crichton ? @Dan Gohman ?) for final evaluation
Last updated: Dec 23 2024 at 12:05 UTC