Stream: general

Topic: wasi-sdk build on windows


view this post on Zulip Dan Gohman (Dec 03 2022 at 01:21):

wasi-sdk Windows builds were broken between windows-2019 20221027.1 and 20221127.1. There's no apparent way to revert it to an older version, and I don't know how to debug the problem. If anyone knows how to debug something involving CMake and Visual Studio and Windows on Github Actions, we could use your help. See https://github.com/WebAssembly/wasi-sdk/pull/263 for details.

This is a test PR; do not merge. I'm trying to determine whether #262 is failing due to the PR itself or due to something else changing. This commit adds an inert change to README.md.

view this post on Zulip Brooks Townsend (Dec 06 2022 at 16:37):

Hey @Dan Gohman , I think i ran into this a few months ago when building things using MSVC for wasmCloud. I think the MSVC toolchain on newer runners, for some reason, doesn't have environment variables set up correctly. Mind if I open a PR into wasi-sdk adding an action (this action: https://github.com/ilammy/msvc-dev-cmd) to see if it works?

(edit: unless https://github.com/WebAssembly/wasi-sdk/pull/265 resolved the issue)

GitHub Action to setup Developer Command Prompt for Microsoft Visual C++ - GitHub - ilammy/msvc-dev-cmd: GitHub Action to setup Developer Command Prompt for Microsoft Visual C++
Closes #264. Note: still a WIP, will undraft and ping for review after: Both x64/x86 builds are ready There's basic testing that msys2 dll dependencies don't leak. make check won't serve this pu...

view this post on Zulip Dan Gohman (Dec 06 2022 at 18:12):

Ah, good to know, thanks! And yes, https://github.com/WebAssembly/wasi-sdk/pull/265 has now gotten our Windows builds back up and running, so we're ok for now.

Closes #264. Note: still a WIP, will undraft and ping for review after: Both x64/x86 builds are ready There's basic testing that msys2 dll dependencies don't leak. make check won't serve this pu...

Last updated: Oct 23 2024 at 20:03 UTC