Stream: general

Topic: Spurious return in tests/wast.rs


view this post on Zulip Mat Gienieczko (Oct 23 2026 at 17:43):

Hey everyone, I found this weird condition in the runner of wast tests (tests/wast.rs)

https://github.com/bytecodealliance/wasmtime/blob/cc032d9f1266768a01df5a06964c3a8748902e5e/tests/wast.rs#L54-L58

It looks like it early-exits the entire test run in case one trial doesn't match some keywords? I'm not sure how to verify this cause I don't know what GC-related tests are, or if this is intentional, but I thought I'd ask if this return shouldn't be a continue instead?

view this post on Zulip Mat Gienieczko (Oct 23 2026 at 17:56):

I see this is used in CI for GC Zeal Tests where it passes a bunch of keywords and indeed, currently that just causes the list of tests to be empty:

> RUSTFLAGS="--cfg gc_zeal" WASMTIME_TEST_GC_KEYWORDS="gc drc any eq struct array i31 extern exn ref rec"  cargo test --test wast -- --list

lists nothing.

view this post on Zulip Mat Gienieczko (Oct 23 2026 at 17:58):

Okay, I'll just open a PR, this is clearly a bug :sweat_smile:

https://github.com/bytecodealliance/wasmtime/pull/14968


Last updated: Oct 31 2026 at 23:03 UTC