Kasey C (Jan 25 2021 at 06:50): Kasey C (Jan 25 2021 at 06:50):I have a question about the etiquette for requesting reviews on PRs to the wasmtime repo.
The documentation says to assign a reviewer from the core team, but that feature is only available to owners and collaborators. It also means that you can't see the list of suggested reviewers.
Is it fine to just open a PR without any reviewer and wait for someone to take a look at it? That seems better than pinging someone semi-randomly in the comments.
Chris Fallin (Jan 25 2021 at 16:15):Hi @Kasey C -- first, thanks for your PR! And yes, at least a few of us monitor the stream of PRs that come in, and someone should pick it up even if it doesn't have a reviewer requested. I'm not sure about the permissions issues / ability to request reviews; we should at least take a look at that policy and consider whether it makes sense. @Till Schneidereit might have more thoughts on this?
Till Schneidereit (Jan 25 2021 at 16:28):I'm unfortunately not aware of any way to change these permissions. What we could and eventually should do is introduce a bot that automatically selects a reviewer, similar to rust-highfive. But that's not something anybody's actively driving right now
Last updated: Dec 23 2024 at 12:05 UTC