yang yu (Mar 30 2023 at 02:17): yang yu (Mar 30 2023 at 02:17):https://github.com/yuyang-ok/isle-analyzer/blob/main/editors/code/README.md
I have been developing IDE support for ISLE language a while.
Right now I think it is ready to launch.
Chris Fallin (Mar 30 2023 at 02:28):Hi @yang yu -- this is really impressive!
I just poked around a bit and it looks like pieces of this are based on code from another LSP server -- e.g. here is originally from here in the Move language's LSP server.
That's basically fine (original is Apache 2 licensed) except you need attribution: ideally you would have git history showing the way the code was derived from the original, or at least have comments everywhere code is borrowed. And you need to make a note of the original copyright and authors, and include the license information. In general we're pretty careful with IP/licensing stuff here because everyone deserves fair attribution for their work :-)
yang yu (Mar 30 2023 at 02:40):sorry somehow the extension not working install from marketplace.
yang yu (Mar 30 2023 at 02:57):@Chris Fallin Sorry about the rush. The extension from marketplace working now.
yang yu (Mar 30 2023 at 05:16):@Chris Fallin I only copied some basic code from that project. nothing important. like setup basic lsp client and server , etc.
Chris Fallin (Mar 30 2023 at 05:23):@yang yu yes, that's a perfectly legitimate thing to do, but as per the license, it needs to be attributed -- that means, citing where the code was copied from. (For example, a comment in the source "borrowed from <url>", and a note in the readme that the project contains Apache 2-licensed code from <project>.) This is a pretty important cultural norm in open-source generally. Sharing code is fine, we just need to share credit too
Chris Fallin (Mar 30 2023 at 05:24):I'll repeat that the project itself is really cool and I look forward to trying it out -- thanks again for building this!
yang yu (Mar 30 2023 at 09:44):@Chris Fallin I am not a licence person, will this do the job?
https://github.com/yuyang-ok/isle-analyzer/commit/a1a8babfaea715b561846f1d8a9f95831a78b036
Chris Fallin (Mar 30 2023 at 16:16):It's a start, yeah. I would recommend adding the Apache 2 license file as well, and a note to the readme that the project is covered under that license
yang yu (Mar 31 2023 at 01:27):@Chris Fallin Thanks,done.
yang yu (Apr 06 2023 at 03:15):@Chris Fallin Are you using this extension,I don't see any feedback. :grinning:
Chris Fallin (Apr 06 2023 at 03:40):I haven't tried it yet, no; I usually use Emacs so I hope to try to extract the LSP server itself and hook it up to lsp-mode. But I haven't gotten around to that yet
yang yu (Apr 06 2023 at 04:04):@Chris Fallin ok
Last updated: Dec 23 2024 at 13:07 UTC