Stream: general

Topic: Cranelift-simplejit build issue

Graham Scheaffer (Jul 04 2020 at 20:46):

I've found an issue with building cranelift-simplejit, is a github issue with the cranelift bugreport template the best way to report it?

bjorn3 (Jul 04 2020 at 20:47):

What is the issue?

Graham Scheaffer (Jul 04 2020 at 20:48):

cranelift-simplejit specifies the dependency region = "2.1.0", but It only builds with version 2.2.0 (latest).

Graham Scheaffer (Jul 04 2020 at 20:49):

Using cranelift v0.65.0 btw

bjorn3 (Jul 04 2020 at 20:50):

:confused: I recently had to change the 2.0.0 requirement to 2.1.0: https://github.com/bytecodealliance/wasmtime/pull/1827 It is suprising that it already needs 2.2.0.

bjorn3 (Jul 04 2020 at 20:51):

What is the exact error?

Graham Scheaffer (Jul 04 2020 at 20:52):

Here is the cargo output: http://ix.io/2qUQ

Graham Scheaffer (Jul 04 2020 at 20:53):

Seems to be a very similar error

bjorn3 (Jul 04 2020 at 20:53):

I am pretty sure I tested it with 2.1.0.

Graham Scheaffer (Jul 04 2020 at 20:55):

To test it I just made an emtpy cargo project and added the following dependencies:

cranelift-simplejit="0.65.0"
region = "=2.1.0"

Graham Scheaffer (Jul 04 2020 at 20:56):

It also happens with region version 2.1.2

bjorn3 (Jul 04 2020 at 20:58):

In that case could you please make a PR to update the region requirement to 2.2.0 everywhere? Both cranelift-sinplejit and the crate of wasmtime that uses region.

Graham Scheaffer (Jul 04 2020 at 20:58):

Yes, I can do that.

Graham Scheaffer (Jul 04 2020 at 21:03):

Are there tests I should run/add to?

Graham Scheaffer (Jul 04 2020 at 21:09):

I submitted the PR.

bjorn3 (Jul 04 2020 at 21:15):

I don't think a test is necessary.

Last updated: Dec 23 2024 at 12:05 UTC