CI failures with wasm C api · general

Stream: general

Topic: CI failures with wasm C api

Benjamin Bouvier (Jul 16 2020 at 13:32):

I'm getting errors that seem unrelated to my PR: https://github.com/bytecodealliance/wasmtime/pull/1995/checks?check_run_id=877766759
Any idea how to solve this?

x64 new backend: most integer opcodes + baldrdash + a bunch of codegen fixes by bnjbvr · Pull Request #1995 · bytecodealliance/wasmtime

I've implemented basic support for Baldrdash so as to be able to run the extensive Spidermonkey test suite, and then could get back to fix a few integer operators implemented before. Also imple...

Alex Crichton (Jul 16 2020 at 13:36):

@Benjamin Bouvier looks like a new nightly thing so pinning to previous nightly should fix

Benjamin Bouvier (Jul 16 2020 at 13:37):

@Alex Crichton how can i do this in Github actions?

Alex Crichton (Jul 16 2020 at 13:38):

There's a line that says rust: nightlt

Alex Crichton (Jul 16 2020 at 13:38):

That can change to nightly-2020-07-xx

Benjamin Bouvier (Jul 16 2020 at 13:38):

thanks, will try!

Alex Crichton (Jul 16 2020 at 13:39):

Sry on phone but will link the exact line soon

Benjamin Bouvier (Jul 16 2020 at 13:39):

I found it, no worries :slight_smile:

Benjamin Bouvier (Jul 16 2020 at 14:12):

Hmm, i tried every nightly down to 07-11's and it still doesn't work. Wasn't the nightly build re-enabled recently?

Benjamin Bouvier (Jul 16 2020 at 14:15):

Ah, it might be that i only changed one place where i should have changed all of them.

Alex Crichton (Jul 16 2020 at 14:20):

oh sorry, beta broke

Alex Crichton (Jul 16 2020 at 14:20):

this is the beta promotion

Alex Crichton (Jul 16 2020 at 14:20):

I think it's probably best if we just fix this, I'll do that shortly

Benjamin Bouvier (Jul 16 2020 at 14:21):

wow, how did i not see the "beta" in all these tests

Benjamin Bouvier (Jul 16 2020 at 14:21):

/me requires more coffee

Alex Crichton (Jul 16 2020 at 14:23):

I'll work on a fix for this

Benjamin Bouvier (Jul 16 2020 at 14:23):

great, cheers

Alex Crichton (Jul 16 2020 at 14:30):

https://github.com/bytecodealliance/wasmtime/pull/2033

Allow `improper_ctypes_definitions` in C API by alexcrichton · Pull Request #2033 · bytecodealliance/wasmtime

This was enabled in rust-lang/rust#72700 but it looks like it's still too noisy for it to be useful to us.

Benjamin Bouvier (Jul 16 2020 at 14:40):

@Alex Crichton Gasp, it seems that it's stable which fails in this case!

Benjamin Bouvier (Jul 16 2020 at 14:41):

error: unknown lint: improper_ctypes_definitions

Alex Crichton (Jul 16 2020 at 14:44):

guh

Last updated: Nov 22 2024 at 16:03 UTC