Cheng Shao (May 13 2021 at 14:14): Cheng Shao (May 13 2021 at 14:14):After https://github.com/bytecodealliance/wasmtime/pull/2897 is merged, in the C API, the only finalizers that need to be called are finalizers for engine/store, right? I checked the examples and there are still calls to other finalizers present (e.g. linker) though
Till Schneidereit (May 13 2021 at 14:23):CC @Alex Crichton
Alex Crichton (May 13 2021 at 14:24):@Cheng Shao mostly, yeah. Finalizers for func/table/instance/memory/global are all being removed since they no longer need to be finalized
Alex Crichton (May 13 2021 at 14:24):modules/config/linker all still need finalization though
Cheng Shao (May 13 2021 at 14:27):@Alex Crichton Thanks for answering! Also, is there still constraint that the finalizers must be run on the same system thread where they are created?
Alex Crichton (May 13 2021 at 14:27):that constraint has been lifted! (one of the major goals of the RFC) -- all finalizers can be run concurrently on any thread
Alex Crichton (May 13 2021 at 14:28):the main reason for that is that finalizers never finalize aliasing data, everything is entirely separately owned (e.g. a linker is entirely disconnected from a store)
Alex Crichton (May 13 2021 at 14:28):(my intention is to cover all this in the documentation, which is yet-to-be-written at this point still)
Cheng Shao (May 13 2021 at 14:29):Excellent news to hear! Thanks for all the hard work. Not before looking at the PR did I realize that there used to be such a constraint
Alex Crichton (May 13 2021 at 14:31):It's not technically so restrictive that it has to be run from the original thread, only that store-related objects (e.g. stores, funcs, globals, memories, etc) must all be dropped on the same thread. They can all migrate somewhere else but it has to be all at once. This is such a fine point though that it's basically technically infeasible
Cheng Shao (May 13 2021 at 14:35):So wasmtime doesn't actually use thread local storage, and as long as there are no concurrent usages from different threads, it doesn't matter where the methods are called?
Alex Crichton (May 13 2021 at 14:37):more-or-less
Alex Crichton (May 13 2021 at 14:37):nonatomic reference counting is used for Store objects today, which is basically the constraint
Alex Crichton (May 13 2021 at 14:38):(but with the new API there's no reference counting at all, everything is separately owned, including the Store)
Last updated: Dec 23 2024 at 13:07 UTC