yang yu (Aug 10 2022 at 00:34): yang yu (Aug 10 2022 at 00:34):I often get this compile error.
image.png
I think this extra check is annoying cause time consuming.
regenerate isle files will cause no problem at all.
Notification Bot (Aug 10 2022 at 00:40):yang yu has marked this topic as resolved.
Notification Bot (Aug 10 2022 at 05:05):yang yu has marked this topic as unresolved.
Chris Fallin (Aug 10 2022 at 16:00):@yang yu it is an intentional safety feature: it is meant to avoid the case where you forget that you have un-set the feature, and continue to look at the code in isle_generated_code and are very confused why it doesn't correspond to what is running
Chris Fallin (Aug 10 2022 at 16:00):so it is annoying in the same way that a type system might be annoying, but it is a safety/correctness check
yang yu (Aug 11 2022 at 00:45):@Chris Fallin it's just when I specify the features on root directory , I get another error.
image.png
maybe I did something wrong???
Chris Fallin (Aug 11 2022 at 00:50):I'm not sure how to resolve that one actually -- the way that features are selected in sub-crates has always been kind of odd to me. I tend to add it to the default feature list (default = ... in cranelift/codegen/Cargo.toml) if I want it to be "sticky" locally -- and just don't commit that change
yang yu (Aug 11 2022 at 01:10):@Chris Fallin I am sorry , I did't read the code carefully .
Is that you never specify the feature and you never get the compile error.
the generate file is in target/... ,the feature is only used you want to read it.
when isle_generated_code directory is generate , we must make sure we ganerate in isle_generated_code directory second time.
otherwise we will have two in isle_generated_code and target directory.
this is powerful, but take more time to digest.
Notification Bot (Aug 11 2022 at 01:13):yang yu has marked this topic as resolved.
Last updated: Nov 22 2024 at 16:03 UTC