Stream: general

Topic: ✔ Arm64Relocations in cranelift-jit

Monadic Cat (Dec 10 2021 at 21:22):

Hi! I'm trying to use cranelift-jit to do some basic JIT compilation on aarch64, but it doesn't support Arm64Call relocations.
It looked pretty simple, so I read some ARM docs and did this: https://github.com/Monadic-Cat/wasmtime/commit/ad36df54951d562c6a0e2c59d37c85bd7d3c7b6b

It appears to work now, so should I open a PR?

Chris Fallin (Dec 10 2021 at 21:34):

@Monadic Cat indeed, we'd be happy to take a PR for this, thanks!

Chris Fallin (Dec 10 2021 at 21:35):

quick drive-by pre-review comment: it'd probably be good to assert that the relative offset is in range rather than silently truncating the upper bits

Monadic Cat (Dec 10 2021 at 21:37):

Good idea. I'll add that. :D

Notification Bot (Dec 11 2021 at 03:28):

Monadic Cat has marked this topic as resolved.

Last updated: Nov 22 2024 at 16:03 UTC